Re: [HIFN 10/n]: Move command descriptor setup to seperate function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 07, 2008 at 02:50:29PM +0200, Patrick McHardy (kaber@xxxxxxxxx) wrote:
> commit 163c74fc4f18d086bbb7f114d55bc7dac939d6b7
> Author: Patrick McHardy <kaber@xxxxxxxxx>
> Date:   Wed May 7 13:11:59 2008 +0200
> 
>     [HIFN]: Move command descriptor setup to seperate function
>     
>     Move command descriptor setup to seperate function as preparation
>     for the following DMA setup fixes.
>     
>     Note 1: also fix a harmless typo while moving it: sa_idx is initialized
>     	to dma->resi instead of dma->cmdi.

Yep, resource and command indexes should be always equal.

>     Note 2: errors from command descriptor setup are not propagated back,
>     	anymore, they can't be handled anyway and all conditions leading
>     	to errors should be checked earlier.
>     
>     Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

I have no objections, thanks Patrick.
Ack.


-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux