Evgeniy Polyakov wrote:
On Wed, May 07, 2008 at 02:26:30PM +0200, Patrick McHardy (kaber@xxxxxxxxx) wrote:
I'm not entirely sure about the alignmask change at the end of
this patch, is an alignmask of 1 correct if no source buffer
alignment is required, but the destination buffer should be
(doesn't have to be though) 4 byte aligned?
commit f76618d53e82c8905214e889a3f79f1816c680fb
Author: Patrick McHardy <kaber@xxxxxxxxx>
Date: Wed May 7 12:44:15 2008 +0200
[HIFN]: Fix data alignment checks
The check for misalignment of the scatterlist data has two bugs:
- the source buffer doesn't need to be aligned at all
- the destination buffer and its size needs to be aligned to a multiple
of 4, not to the crypto alg blocksize
If memory serves me right, both src and dst addresses have to be 4 bytes
aligned. Protocol alignment is not needed.
If it is not the issue, then I have no objections.
Of the data buffers only the destination buffer needs to be aligned,
see the Source Pointer description in "2.2 Source Descriptors" in
the HIFN documentation.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
