On Sat, Dec 08, 2007 at 11:31:30PM +0800, Tan Swee Heng wrote: > > Some thoughts: > I detected this when testing against the large test vector. For small > test vectors, the blkcipher_walk code uses source and destination > buffers that are equal. Only near the page boundary, does > blkcipher_walk uses different buffers. (At least this is true on my > system from what I've observed.) Since many of the tcrypt test vectors > are small, therefore src == dst frequently when blkcipher_walk-ing. It > seems to imply that most of the *_segment() code in the block cipher > modes are seldom tested. Perhaps this is something that a new tcrypt > framework should address. We could change tcrypt to run every test twice, once as in-place and once as not-in-place. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
