On Wed, Nov 28, 2007 at 07:09:08AM +0800, Tan Swee Heng wrote: > > The final patch (combining yours and the two fixes) is attached to this email. Thanks! I've added it to cryptodev-2.6. > One question: Can we use crypto_cipher_encrypt_one() in both > _segment() and _inplace()? It reads better than the function pointer > fn(). Normally that's what we'd use. However, these two functions are performance-critical and reading the pointer out potentially allows better optimisations since the compiler now knows that we're calling the same function rather than potentially different functions each time. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
