On Wed, Nov 21, 2007 at 12:23:49AM -0800, Denys Vlasenko wrote: > On Wednesday 21 November 2007 00:22, Denys Vlasenko wrote: > > Patches start from 5 because pathches 1..4 are already > > in cryptodev-2.6. > > > > camellia5: > > adds 64-bit key setup, it is used if BITS_PER_LONG is 64. > > > Signed-off-by: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> Denys, I really appreciate your work in cleaning this algorithm up. However, I just can't accept 600 lines of new code just to do setkey faster/smaller on 64-bit platforms. You know, some people have to study these files line-by-line in order have them pass government certifications and such. OK I went back and looked at the figures, so we're talking about either 1K extra on 64-bit if we use the 32-bit version or 2K extra on 32-bit if we went for the 64-bit version. Either way it doesn't seem to be a big deal. So how about just picking one and sticking with it? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
