On Tuesday 20 November 2007 19:53, Herbert Xu wrote: > On Sun, Nov 18, 2007 at 08:30:16PM -0800, Denys Vlasenko wrote: > > Oh, Herbert, have heart, my camellia.c source file is smaller > > than the one I started from. It's not like it's twice as big. > > It's smaller already. > > > > 64-bit key setup is not just faster, it is also smaller > > by ~4k, and this benefit is always there, not only when > > key setup is performed. > > The key setup path is the slow path so I don't see why we can't > just switch to the 64-bit version if it's better. Yes, with minor modifications "64-bit" version can be compiled and will work correctly on 32-bit CPU. But it will be larger. This is what I got on i386: text data bss dec hex filename 18230 224 0 18454 4816 t/crypto/camellia.o 20198 224 0 20422 4fc6 t_fake64/crypto/camellia.o > BTW I tried to apply your -6 patch but it doesn't apply against > cryptodev-2.6 so I had to drop it. Will correct this and re-post. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html