Hi, >> Sun, 18 Nov 2007 20:30:16 -0800 >> [Subject: Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization] >> Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> wrote... > > > camellia6: > > > unifies encrypt/decrypt routines for different key lengths. > > > This reduces module size by ~25%, with tiny (less than 1%) > > > speed impact. > > > Also collapses encrypt/decrypt into more readable > > > (visually shorter) form using macros. > > And here is > > camellia7: > Move "key XOR is end of F-function" code part into > camellia_setup_tail(), it is sufficiently similar > between camellia_setup128 and camellia_setup256. > This shaves off another ~1k: > dec hex filename > 21414 53a6 2.6.23.1.camellia6.t/crypto/camellia.o > 20518 5026 2.6.23.1.camellia7.t/crypto/camellia.o > 16355 3fe3 2.6.23.1.camellia6.t64/crypto/camellia.o > 15813 3dc5 2.6.23.1.camellia7.t64/crypto/camellia.o > > > At the moment I cannot run test it, try to do it ASAP. > > Takamiya-san, can you review attached patch please? Sorry for late reply. I think you're testing now:-), and if speed impact is less than 1% as you say, I think it is acceptable. The smaller code size is, the easier to enable camellia in the embedded systems. Regards, Acked-by: Noriaki TAKAMIYA <takamiya@xxxxxxxxxxxxx> -- Noriaki TAKAMIYA - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
