Re: [PATCH 1/1]: Add countersize to CTR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 26, 2007 at 02:22:28PM -0500, Joy Latten wrote:
>
> Ok, I added 2 additional checks; one check
> that countersize >= 4 and the other that 
> noncesize+ivsize+countersize >= blocksize.
>  
> I think the addition of these two checks help
> to cover instances where we will want to fail
> because of our inputs. 
> 
> The below patch covers the additional checks as
> well as the changes for GCM.

Looks great.  Thanks Joy!

BTW, please check your patches for white space errors with

git apply --check --whitespace=error-all your-patch

I've fixed them up this time.  Actually, I must've fixed them
up last time too because your patch didn't apply against my
tree :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux