Re: [PATCH 2/5] camellia: cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 25, 2007 at 12:45:42PM +0100, Denys Vlasenko wrote:
> On Thursday 25 October 2007 12:43, Denys Vlasenko wrote:
> > Hi Hervert,
> > 
> > Please review and maybe propagate upstream following patches.
> > 
> > camellia2.diff
> >     Rename some macros to shorter names: CAMELLIA_RR8 -> ROR8,
> >     making it easier to understand that it is just a right rotation,
> >     nothing camellia-specific in it.
> >     CAMELLIA_SUBKEY_L() -> SUBKEY_L() - just shorter.
> > 
> >     Move be32 <-> cpu conversions out of en/decrypt128/256 and into
> >     camellia_en/decrypt - no reason to have that code duplicated twice.
> 
> Signed-off-by: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>

Patch applied.  BTW, we have a function called ror32 that can
replace all of these ROR* macros.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux