On Mon, Oct 22, 2007 at 07:22:12PM +0200, Sebastian Siewior wrote: > From: Sebastian Siewior <sebastian@xxxxxxxxxxxxx> > > There are three AES softwore modules in the kernel: One C version > and two arch specific assembly versions. The key expansion routine as > well as the the four lookup tables which are used during encryption > and/or decryption are the same. > This patch simply creates an independent module which shares the > data structures across the modules. > > Signed-off-by: Sebastian Siewior <sebastian@xxxxxxxxxxxxx> Thanks, the patch looks fine. However, instead of creating yet another module like twofish, how about just making the assembly versions depend on the generic version for these functions? In fact, that's how we should've handled twofish as well. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
