On Tue, Oct 23, 2007 at 07:59:22PM -0500, Michael Halcrow wrote:
>
> It is usually appropriate to print something to the system log when
> there is an error condition in the kernel code. That can help triage
> down the road when people have troubles.
>
> The only reason I can think of as to why we would *not* want
> explanations in the syslog for failures is if frequent failures are
> expected in a significant fraction of deployments.
These paths can be triggered from user-space in future so printks
are not appropriate.
> > > > - test_cipher("ctr(aes,4,8)", ENCRYPT, aes_ctr_enc_tv_template,
> > > > + test_cipher("ctr(aes,4,8,4)", ENCRYPT, aes_ctr_enc_tv_template,
> > > > AES_CTR_ENC_TEST_VECTORS);
> > > > - test_cipher("ctr(aes,4,8)", DECRYPT, aes_ctr_dec_tv_template,
> > > > + test_cipher("ctr(aes,4,8,4)", DECRYPT, aes_ctr_dec_tv_template,
> > > > AES_CTR_DEC_TEST_VECTORS);
> > >
> > > I have never been particularly thrilled about the the string-based
> > > method of parameterizing block ciphers for in-kernel API calls.
> >
> > If you have a better suggestion I'd love to hear it!
>
> Well, for calls made internally from kernel functions to kernel
> functions, pretty much anything other than writing sequences of
> comma-delimited parameters into to a character string.
Again these parameters ultimately come from user-space so this
doesn't sound very practical.
Even for the kernel users how would you type these parameters?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
