On Sun, Oct 21, 2007 at 08:16:25PM +0100, Denys Vlasenko wrote: > Hello Herbert, > > Currently twofish cipher key setup code > has unrolled loops - approximately 70-100 > instructions are repeated 40 times. > > As a result, twofish module is the biggest module > in crypto/*. > > Attached patch conditionalize this unrolling on > CONFIG_CC_OPTIMIZE_FOR_SIZE. Presumably, people which > want to use -Os will also prefer to not have these loops > unrolled: Thanks for the patch Denys. Have you looked at the performance figures on x86 for the two variants? If the difference is small we could just get rid of the unrolled version altogether. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
