Re: [1/1 take 3] HIFN 795x driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 10, 2007 at 07:21:47PM +0400, Evgeniy Polyakov wrote:
>
> It passed all tests for AES, DES and DES3_EDE except weak test for DES,
> since hardware can not determine weak keys.

Patch applied. Thanks Evgeniy!

BTW, we should change it so that the DES algorithm's setkey
function uses the same weak-key test as used by the generic
DES code.

Oh I had to apply the following fix-up in order for it to build
against cryptodev-2.6.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/arch/s390/crypto/sha1_s390.c b/arch/s390/crypto/sha1_s390.c
diff --git a/arch/s390/crypto/sha256_s390.c b/arch/s390/crypto/sha256_s390.c
diff --git a/crypto/sha1_generic.c b/crypto/sha1_generic.c
diff --git a/crypto/sha256_generic.c b/crypto/sha256_generic.c
diff --git a/crypto/sha512.c b/crypto/sha512.c
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 6c446f3..b6c1ee1 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -1945,11 +1945,10 @@ static int hifn_handle_req(struct ablkcipher_request *req)
 		err = hifn_setup_session(req);
 
 	if (err == -EAGAIN) {
-		struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(req);
 		unsigned long flags;
 
 		spin_lock_irqsave(&dev->lock, flags);
-		err = ablkcipher_enqueue_request(crypto_ablkcipher_alg(tfm), req);
+		err = ablkcipher_enqueue_request(&dev->queue, req);
 		spin_unlock_irqrestore(&dev->lock, flags);
 	}
 
@@ -2359,7 +2358,6 @@ static int hifn_alg_alloc(struct hifn_device *dev, struct hifn_alg_template *t)
 	alg->alg.cra_module = THIS_MODULE;
 	alg->alg.cra_u.ablkcipher = t->ablkcipher;
 	alg->alg.cra_init = hifn_cra_init;
-	alg->alg.cra_ablkcipher.queue = &dev->queue;
 
 	alg->dev = dev;
 
diff --git a/drivers/crypto/padlock-sha.c b/drivers/crypto/padlock-sha.c
diff --git a/include/crypto/sha.h b/include/crypto/sha.h
diff --git a/include/linux/crypto.h b/include/linux/crypto.h
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux