* Evgeniy Polyakov | 2007-10-02 19:00:13 [+0400]: >DES currently does not pass tcrypt's multipage test, since HIFN adapter >can not work with non-blocksize aligned chunks, although crypto alignmask >is set to 3, tcrypt provides a block of size 2 in its multipage test, >which fails. I recalled now that I forgot to point this out. You set the align mask to the block size of the algorithm but it is almost unused / useless. Let me explain: - it is ensured that the key you get (in the setkey function) is properly aligned. This doesn't matter in your case because you memcpy() the key away to your private struct. - your private struct is pointer aligned (if I remember correctly). You memcpy() your key away so it looks like you don't need the ctx aligned according to your mask (but it would be possible :)) - the proper alignment of src, dst and the IV that you get is _not_ ensured. This would be the case if you would develop a blkcipher and use blkcipher_walk_init(), blkcipher_walk_virt(), .... Now. If you pass your AES-tcrypt-test (where you need 16 bytes alignment) than this is pure luck. If you really need aligned src,dst or the IV than you have to do it by yourself :( The alignment for blkcipher (crypto/blkcipher.c) is enforced via - blkcipher_walk_first() by calling blkcipher_copy_iv() for the IV - blkcipher_walk_next() (and later) for the src/dst addr Herbert: maybe we should remove the alignment in tcrypt.h (and make it unaligned on purpose) so we can test if the crypto API is enforcing the required alignment properly as well as the HW drivers. Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
