On Thu, Aug 16, 2007 at 10:01:06PM +0200, Sebastian Siewior wrote: > This cast allows to regain the struct ablkcipher_request for a request > from private data. Hi Sebastian: I think this function would make more sense as a private function in your driver. That way you can give it an explicit type rather than having it take a void *. We want to avoid unnecessary casting like this where possible as it's error-prone. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html