Re: [crypto] fix writting into unallocated memory in setkey_aligned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Herbert Xu | 2007-08-03 20:34:25 [+0800]:

>On Thu, Aug 02, 2007 at 02:57:43PM +0200, Sebastian Siewior wrote:
>> setkey_unaligned() commited in ca7c39385ce1a7b44894a4b225a4608624e90730
>> overwrites unallocated memory in the following memset() because I used the
>> wrong buffer length.
>
>Good catch.  Thanks!
>
>We don't have any in-tree users that will trigger this right
>now do we?

Why not? This is used by _any_ cipher/hash/... user in tree. Most of
algos specify an alignment of 3 what is very likely to become. I
checked IPsec and they allocated keys with an alignment of 7.
padlock-aes specifies an alignment of 15 so there is a 50-50 chance that
it will go well :)
I don't know if you count this as user, but tcrypt.c has an alignment of
3 and the tgr hash needs 7.

>Cheers,

Cheers,
Sebastian
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux