Re: [PATCH] crypto/aes.c remove operator ? and variable t in bf_setkey

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 16, 2007 at 02:52:34AM +0200, Frederik Sdun wrote:
> 
> this removes the the ? operator which is false nearly all the time.

These changes look good.  Could you please resend them as
patches that can be directly applied and add a sign-off?
You can refer to Documentation/SubmittingPatches for detailed
instructions.

> --- aes.c.orig  2007-07-15 11:43:21.000000000 +0200
> +++ aes.c       2007-07-16 01:56:49.000000000 +0200
> @@ -156,9 +156,12 @@
>  
>                 p = (p << 1) ^ (p & 0x80 ? 0x01b : 0);
>         }
> +
> +       sbx_tab[0] = 0x63;
> +       isb_tab[0x63] = (u8) 0;

Please kill that cast.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux