* Evgeniy Polyakov | 2007-06-04 17:42:48 [+0400]:
>+struct hifn_device
>+{
>+ struct pci_dev *pdev;
>+ spinlock_t lock;
>+ u8 current_key[HIFN_MAX_CRYPT_KEY_LENGTH];
>+ int current_key_len;
>+ struct list_head alg_list;
>+};
...
This struct looks to me like one per real hardware. What are you doing
if you get two+ crypto users? Or is this struct one per crypto user?
This is what gets allocated by crypto api for every user.
>+static void hifn_work(struct work_struct *);
>+
>+static int hifn_start_device(struct hifn_device *dev)
>+{
...
>+ INIT_DELAYED_WORK(&dev->work, hifn_work);
>+ schedule_delayed_work(&dev->work, HZ);
>+
>+ return 0;
>+}
...
>+static irqreturn_t hifn_interrupt(int irq, void *data)
...
This looks to me like you have to reset the hardware once in a while.
The worker func and the interrupt handler are the only two functions
(exept hifn_remove()) that know about your hardware at run time.
>+static int hifn_setkey(struct crypto_ablkcipher *cipher, const u8 *key, unsigned int len)
>+{
>+ struct crypto_tfm *tfm = crypto_ablkcipher_tfm(cipher);
>+ struct hifn_device *dev = crypto_tfm_ctx(tfm);
>+
>+ if (len > HIFN_MAX_CRYPT_KEY_LENGTH)
>+ return -1;
>+
>+ if (!memcmp(dev->current_key, key, len)) {
>+ dev->flags |= HIFN_FLAG_OLD_KEY;
>+ return 0;
>+ }
>+
>+ dev->flags &= ~HIFN_FLAG_OLD_KEY;
>+
>+ memcpy(dev->current_key, key, len);
>+ dev->current_key_len = len;
>+
>+ return 0;
>+}
...
dev is allocated by the crypto API but isn't initialized right? Nothing
points to your real hw right?
I (in my case) assign directly key ctx to hw ctx in set_key. This is
crap because more than just one hw could exist. The API chooses the
algo with the highest prio so you can't use more than one device.
A load balancer could be the person in charge for assigning hw ctx to
crypto user ctx.
>+static inline int hifn_encrypt_aes_ecb_16(struct ablkcipher_request *req)
>+{
>+ return hifn_setup_crypto(req, ACRYPTO_OP_ENCRYPT, ACRYPTO_TYPE_AES_128, ACRYPTO_MODE_ECB);
>+}
...
This is what I had in mind, as I said look on my skeleton, than you will
see how you can distinguish which algo is requested. Since you have 12
algos I understand now what you meant with "it doesn't" and your cat :)
> Evgeniy Polyakov
Sebastian
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
