Evgeniy Polyakov <johnpol@xxxxxxxxxxx> wrote: > > It does not - your code only supposed to work with ecb, since it is what > was requested during initialization time. This new scheme with templates > helps alot for ciphers/crypto modes which do not support several > templates, so I used old scheme with 'cipher' only template, not > 'ecb(cipher)', 'cbc(cipher)' and so on. I just had a look and your driver should use the cra_name of "ecb(aes)" since ECB is what it implements. The cra_driver_name can be ecb-aes-hifn (if there can only be one hifn device, otherwise make it something like ecb-aes-hifn-<devname> or ecb-aes-<devname>). Your priority should also be above 200 which is where assembly-optimised software algorithms are registered at by default. I suggest 300. > HIFN supports at least 12 different ciphers/mode (3des, des and aes, > each one with 4 modes), so it is not a good idea to put them all into > separated structures, so I rised a question about it. Well it is a trade-off of a bit of work here vs. the ability to better support new cipher modes that arise. Could we perhaps use macro helpers so that you don't have to type out each one by hand? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
