* Herbert Xu | 2007-05-19 17:41:36 [+1000]: >I think we should stick with GFP_ATOMIC for now. Once all the atomic >users have been fixed (if they can be), then we can start changing this >interface. okey. >> +static int setkey_unaligned(struct crypto_tfm *tfm, const u8 *key, unsigned int keylen, >> + unsigned long alignmask) > >Minor nit. Could you get rid of the alignmask parameter here and just >read it again from tfm? This should make it easier for certain compiler/ >arch combos to generate a tail call. sure >> + if ((unsigned long) key & alignmask) > >Please kill the space before key. okey. >Thanks, Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
