* Herbert Xu | 2007-05-18 23:46:32 [+1000]: >> Good point. I take kmalloc() with GFP_KERNEL (the caller should not be >> atomic at this point). Additionaly I zero the temporary key (I don't > >They shouldn't be. But it would be good if you could do a grep to see >if any of them are doing it in an atomic context since we've not tested >for this before. Huh, this was too fast. I greped after sending the patch... drivers/net/ppp_mppe.c: can't tell, probably not. net/mac80211/wep.c: caller is requesting memory with GFP_ATOMIC. The code might get called from a tasklet handler but can't really say. There are some skbs around. The others are pretty easy to tell and they don't, just the mac80211. Do you s/GFP_KERNEL/GFP_ATOMIC/ ? >Thanks, Sebastian - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html