Hello Herbert, On Wed, Nov 29, 2006 at 08:13:40AM +1100, Herbert Xu wrote: > > It's OK. The source will be more maintainable, but constantly converting > > between big and little-endian (on little endian machines) may have a > > significant performance impact (I will just test when your gf128 hits > > cryptodev-2.6, and complain if it is the case). > > BTW, the tcrypt speed test for lrw doesn't work for me. Did you try my patch: [PATCH] adding speed_test_template for lrw(aes) which I sent on Sep 23? > > This seems to be the problem, the table is constructed wrongly. > > All the calculations take place as if we are on a big endian machine, so > > the table entries should never be swapped, so the above line should read > > > > +#define xx(p, q) 0x##p##q > > Yes you're quite right. That was the problem. I'll push this into mm > as soon as I get the speed tests fixed. Ok, that's good news. Greetings, Rik. -- Nothing is ever a total loss; it can always serve as a bad example. - To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
