Re: crypto/des.c cleanups for review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 16, 2006 at 02:05:16AM -0500, linux@xxxxxxxxxxx wrote:
> I sent this to <da@xxxxxxxx> on Nov. 1, but have received no response.
> Is anyone interested?  The changes are all mixed up together, but I can
> break them apart into a patch series if desired.

Yes breaking them into more related chunks would be good (although
it is also good to not go overboard with too many one-liners :)
 
> (All placed in the public domain if you want to use them.)

I'm sorry but I'm going to need a sign-off here (as per
Documentation/SubmittingPatches).

> -	memcpy(dctx->expkey, tmp, sizeof(dctx->expkey));
> +	memcpy(dctx->expkey, tmp, sizeof dctx->expkey);

Please keep the brackets as that is the predominant kernel style.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux