Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Apr 30, 2014 at 03:17:54PM -0400, Milos Vyletel wrote:
> Coverity detected possible use of uninitialized pointer when printing info
> message during module load. While this is higly unlikely to cause any troubles
> simple change in sha1_ssse3_mod_init to make it look like sha256/512 init
> function will fix this.
> 260
>    	6. Condition sha1_transform_asm, taking true branch
> 261        if (sha1_transform_asm) {
> CID 1195603 (#1 of 1): Uninitialized pointer read (UNINIT)
> 7. uninit_use_in_call: Using uninitialized value algo_name when calling printk.
> 262                pr_info("Using %s optimized SHA-1 implementation\n", algo_name);
> 263                return crypto_register_shash(&alg);
> 264        }
> Reported-by: <scan-admin@xxxxxxxxxxxx>
> Signed-off-by: Milos Vyletel <milos.vyletel@xxxxxxxxx>

Unless I'm missing something there is no way this code can use
the variable without initialising it.

So this is a false positive and I'm not applying this.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-coverity" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux