On Thu, Mar 24, 2022 at 2:49 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> I don't see how passing in struct cred does anything helpful. The
> namespace can not be found in struct cred.
Duh. For some reason I thought we had it there, but yeah, that only
contains the user-namespace.
The rest is in tsk->nsproxy.
So it would have to be squirrelled away in some other way.
> But all of these cleanups I see are moving forward from the current
> point so I don't see why we would not want to merge the code as is
> and then get the tested versions of my cleanups below.
What part of "that code is too ugly to live" did not end up registering.
Maybe it can be cleaned up. But it had better be cleaned up before I pull it.
Linus
