Re: [PATCH v3 17/38] namei: introduce struct renamedata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +int vfs_rename(struct renamedata *rd)
>  {
>  	int error;
>  	struct user_namespace *user_ns = &init_user_ns;
> +	struct inode *old_dir = rd->old_dir, *new_dir = rd->new_dir;
> +	struct dentry *old_dentry = rd->old_dentry,
> +		      *new_dentry = rd->new_dentry;

This looks weird.  I'd just write the obvious:

	struct dentry *old_dentry = rd->old_dentry;
	struct dentry *new_dentry = rd->new_dentry;
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers



[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux