Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 25, 2016 at 09:42:07PM -0500, Serge E. Hallyn wrote:
> > Looking at it another way...  The value we're talking about shows us
> > the path of the root dentry of a cgroup mount.  If a task in cgns2
> > rooted at /a/b/c mounts a cgroupfs, it will see '/' as the root dentry.
> > If a task in cgns1 rooted at /a/b looks at that mountinfo, '/' would
> > be misleading.  It really should be '/c'.
> 
> So I think that for cgroup mount entries in mountinfo to be useful (i.e.
> to criu) we either need the root dentry path to be given as relative to
> the reader's cgroup namespace (as I have it in this patchset), or else
> we need to add another piece of information in the mountinfo entry, such
> as the nsfd inode number of the cgroup namespace in which it was
> mounted.

In the ideal world there is no mountinfo file, but /proc/self/mountinfo/<id>/
directory with individual files, so every subsystem and filesystem has 
absolute freedom to store there all relevant information. The result will 
be also lucky kernel that does not have to always generate entire huge 
mountinfo file for all mountpoins... etc. :-)

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers



[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux