On Tue, Nov 24, 2015 at 11:16:30AM -0500, Tejun Heo wrote:
> Hello,
>
> On Mon, Nov 16, 2015 at 01:51:38PM -0600, serge@xxxxxxxxxx wrote:
> > +static char * __must_check kernfs_path_from_node_locked(
(Note I've rewritten this to find a common ancestor and walk back to
and from that, as you suggested later in this email)
> > + /* Short-circuit the easy case - kn_to is the root node. */
> > + if ((kn_from == kn_to) || (!kn_from && !kn_to->parent)) {
> > + *p = '/';
> > + *(p + 1) = '\0';
>
> Hmm... so if kn_from == kn_to, the output is "/"?
Yes, that's what seems to make the most sense for cgroup namespaces. I
could see a case for '.' being used instead in general, but for cgroup
namespaces I think we'd have to convert those back to '/'. Otherwise
we'll fail in being able to run legacy software, which would get
confused.
-serge
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
