On 10/13, Chen, Hanxiao wrote: > > > At the same time, for_each_process() in the global namespace can be > > faster if there are a lot of sub-threads. > > > > > Perhaps that's not a good way. > > > > OK, I won't insist. > > > > although it would be nice to know why do you think this is bad. > > > I worried about it may slower in global namespace. > But it will provide a great convenient way when query pid hierarchy > when not in init_pid_ns. Yes, it is not clear what is actually better, so ... > I'll post a new patch using find_ge_pid + get_pid Only if you think this makes more sense. I do not have a strong opinion. And we can change the implementation at any time. The real problem is the API this patch adds. I leave this to you and other reviewers who understand the problem space better ;) Just I think that the changelog could say a bit more, to explain why do we need this patch. IOW, explain the problem and how/why this patch helps. Oleg. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
