Re: [REVIEW][PATCH 1/3] vfs: In d_path don't call d_dname on a mount point

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 30, 2013 at 05:02:26PM +0000, Al Viro wrote:

> FWIW, the other callers of prepend_path() boil down to /proc/mountinfo
> handling, apparmour d_namespace_path() (separate handling of MNT_INTERNAL,
> __d_path() or d_absolute_path() for the rest) and tomoyo_get_absolute_path()
> (this one directly calls ->d_dname() itself).

While we are at it, what's the origin of if (buflen >= 256) checks in
tomoyo_get_absolute_path() and tomoyo_get_dentry_path()?  The minimal
buflen value they can be called with is PAGE_SIZE - 1.  And if there is
a port with pages two times smaller than VAX ones, they'd better audit
the tree for places assuming that PAGE_SIZE is at least 4K...
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers




[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux