> @@ -3841,6 +3851,7 @@ static const struct file_operations cgroup_pidlist_operations = {
> static int cgroup_pidlist_open(struct file *file, enum cgroup_filetype type)
> {
> struct cgroup *cgrp = __d_cgrp(file->f_dentry->d_parent);
> + struct cgroup_pidlist_open_file *of;
> struct cgroup_pidlist *l;
> int retval;
>
> @@ -3851,12 +3862,17 @@ static int cgroup_pidlist_open(struct file *file, enum cgroup_filetype type)
> /* configure file information */
> file->f_op = &cgroup_pidlist_operations;
>
> - retval = seq_open(file, &cgroup_pidlist_seq_operations);
> + retval = seq_open_private(file, &cgroup_pidlist_seq_operations,
> + sizeof(*of));
should be a bit simpler to use __seq_open_private():
of = __seq_open_private(...);
if (!of) {
...
return -ENOMEM;
}
and then @retval can be removed in 6/7.
> if (retval) {
> cgroup_release_pid_array(l);
> return retval;
> }
> - ((struct seq_file *)file->private_data)->private = l;
> +
> + of = ((struct seq_file *)file->private_data)->private;
> + of->type = type;
> + of->cgrp = cgrp;
> + of->pidlist = l;
> return 0;
> }
> static int cgroup_tasks_open(struct inode *unused, struct file *file)
>
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
