On Wed, Aug 21, 2013 at 06:00:09PM +0800, Li Zefan wrote: > @@ -887,10 +888,17 @@ static void update_cpumasks_hier(struct cpuset *cs, struct cpuset *trialcs, > > update_tasks_cpumask(cp, heap); > > + if (!cpumask_empty(cp->cpus_allowed) && > + is_sched_load_balance(cp)) > + need_rebuild_sched_domains = true; > + > rcu_read_lock(); > css_put(&cp->css); > } > rcu_read_unlock(); > + > + if (need_rebuild_sched_domains) > + rebuild_sched_domains_locked(); > } > > /** > @@ -944,9 +952,6 @@ static int update_cpumask(struct cpuset *cs, struct cpuset *trialcs, > update_cpumasks_hier(cs, trialcs, &heap); > > heap_free(&heap); > - > - if (is_sched_load_balance(cs)) > - rebuild_sched_domains_locked(); Hmmm... can we please document what's going on with the above call and add some comment explaining what it's doing and why it's where it's at? Thanks. -- tejun _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers