On Mon, Jun 24, 2013 at 06:33:19PM +0800, Li Zefan wrote: > On 2013/6/22 9:34, Tejun Heo wrote: > > find_css_set() passes uninitialized on-stack template[] array to > > find_existing_css_set() which sets the entries for all subsystems. > > Passing around an uninitialized array is a bit icky and we want to > > introduce an iterator which only iterates loaded subsystems. Let's > > initialize it on definition. > > > > While at it, also make the following cosmetic cleanups. > > > > * Convert to proper /** comments. > > > > I thought we only use this for external functions, but then I read > Documentation/kernel-doc-nano-HOWTO.txt: > > We also recommend providing kernel-doc formatted documentation > for private (file "static") routines, for consistency of kernel > source code layout. But this is lower priority and at the > discretion of the MAINTAINER of that kernel source file. Yeah, for functions which are tricky, important and/or used in many different places, I prefer proper function comments. There really is no reason not to do it. Thanks. -- tejun _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
