On 2013/6/22 9:34, Tejun Heo wrote:
> cgroup curiously has two subsystem masks, ->subsys_mask and
> ->actual_subsys_mask. The latter only exists because the new target
> subsys_mask is passed into rebind_subsystems() via @cgrp->subsys_mask.
s/cgrp->/root->/
> rebind_subsystems() needs to know what the current mask is to decide
> how to reach the target mask so ->actual_subsys_mask is used as the
> temp location to remember the current state.
>
> Adding a temporary field to a permanent data structure is rather silly
> and can be misleading. Update rebind_subsystems() to take @added_mask
> and @removed_mask instead and remove @cgrp->actual_subsys_mask.
>
ditto
> This patch shouldn't introduce any behavior changes.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
> include/linux/cgroup.h | 3 ---
> kernel/cgroup.c | 22 ++++++++++++----------
> 2 files changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
> index 46a59d0..7d8c4ec 100644
> --- a/include/linux/cgroup.h
> +++ b/include/linux/cgroup.h
> @@ -295,9 +295,6 @@ struct cgroupfs_root {
> /* Unique id for this hierarchy. */
> int hierarchy_id;
>
> - /* The bitmask of subsystems currently attached to this hierarchy */
> - unsigned long actual_subsys_mask;
> -
I think it's better to change this comment:
/*
* The bitmask of subsystems intended to be attached to this
* hierarchy
*/
unsigned long subsys_mask;
to
/* The bitmask of subsystems attached to this hierarchy */
> /* A list running through the attached subsystems */
> struct list_head subsys_list;
>
Other than those comments:
Acked-by: Li Zefan <lizefan@xxxxxxxxxx>
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
