Re: [PATCH 2/2] cgroups: fix cgroup_event_listener error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> cgroups: fix cgroup_event_listener error handling
> 
> The error handling in cgroup_event_listener.c did not correctly deal
> with either an error opening either <control_file> or
> cgroup.event_control.  Due to an uninitialized variable the program
> exit code was undefined if either of these opens failed.
> 
> This patch simplifies and corrects cgroup_event_listener.c error
> handling by:
> 1. using err*() rather than printf(),exit()
> 2. depending on process exit to close open files
> 
> With this patch failures always return non-zero error.
> 
> Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>

Acked-by: Li Zefan <lizefan@xxxxxxxxxx>

> ---
>  tools/cgroup/cgroup_event_listener.c |   72 ++++++++++-----------------------
>  1 files changed, 22 insertions(+), 50 deletions(-)

_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers


[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux