Hello, Michal. On Wed, Nov 07, 2012 at 04:25:16PM +0100, Michal Hocko wrote: > > This patch adds ->post_create(). It's called after all ->create() > > succeeded and the cgroup is linked into the generic cgroup hierarchy. > > This plays the counterpart of ->pre_destroy(). > > Hmm, I had to look at "cgroup_freezer: implement proper hierarchy > support" to actually understand what is the callback good for. The above > sounds as if the callback is needed when a controller wants to use > the new iterators or when pre_destroy is defined. > > I think it would be helpful if the changelog described that the callback > is needed when the controller keeps a mutable shared state for the > hierarchy. For example memory controller doesn't have any such a strict > requirement so we can safely use your new iterators without pre_destroy. Hmm.... will try to explain it but I think it might be best to just refer to the later patch for details. It's a bit tricky to explain. Thanks. -- tejun _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers