Hello, Michal.
On Wed, Nov 07, 2012 at 12:00:57PM +0100, Michal Hocko wrote:
> > + * Update all its descendants in pre-order traversal. Each
> > + * descendant will try to inherit its parent's FREEZING state as
> > + * CGROUP_FREEZING_PARENT.
> > + */
> > + rcu_read_lock();
> > + cgroup_for_each_descendant_pre(pos, freezer->css.cgroup) {
> > + struct freezer *pos_f = cgroup_freezer(pos);
> > + struct freezer *parent = parent_freezer(freezer);
>
> This doesn't seem right. Why are we interested in freezer->parent here
> at all? We should either care about freezer->state & CGROUP_FREEZING or
> parent = parent_freezer(pos_f), right?
Yeap, that should have been parent_freezer(pos_f). Argh...
Thanks.
--
tejun
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
