(2012/10/31 13:22), Tejun Heo wrote: > 2ef37d3fe4 ("memcg: Simplify mem_cgroup_force_empty_list error > handling") removed the last user of __DEPRECATED_clear_css_refs. This > patch removes __DEPRECATED_clear_css_refs and mechanisms to support > it. > > * Conditionals dependent on __DEPRECATED_clear_css_refs removed. > > * ->pre_destroy() now can only fail if a new task is attached or child > cgroup is created while ->pre_destroy()s are being called. As the > condition is checked again after re-acquiring cgroup_mutex > afterwards, we don't need to take any immediate action on > ->pre_destroy() failures. This reduces cgroup_call_pre_destroy() to > a simple loop surrounding ->pre_destory(). Remove > cgroup_call_pre_destroy() and open-code the loop into > cgroup_rmdir(). > > * cgroup_clear_css_refs() can no longer fail. All that needs to be > done are deactivating refcnts, setting CSS_REMOVED and putting the > base reference on each css. Remove cgroup_clear_css_refs() and the > failure path, and open-code the loops into cgroup_rmdir(). > > Note that cgroup_rmdir() will see more cleanup soon. > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> I thank you and Michal for this work. Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxx> _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers