On Tue, Oct 30, 2012 at 09:22:45PM -0700, Tejun Heo wrote: > All ->pre_destory() implementations return 0 now, which is the only > allowed return value. Make it return void. > > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > Cc: Michal Hocko <mhocko@xxxxxxx> > Cc: Balbir Singh <bsingharora@xxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Cc: Vivek Goyal <vgoyal@xxxxxxxxxx> > --- > block/blk-cgroup.c | 3 +-- > include/linux/cgroup.h | 2 +- > kernel/cgroup.c | 2 +- > mm/hugetlb_cgroup.c | 4 +--- > mm/memcontrol.c | 3 +-- > 5 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > index f3b44a6..a7816f3 100644 > --- a/block/blk-cgroup.c > +++ b/block/blk-cgroup.c > @@ -600,7 +600,7 @@ struct cftype blkcg_files[] = { > * > * This is the blkcg counterpart of ioc_release_fn(). > */ > -static int blkcg_pre_destroy(struct cgroup *cgroup) > +static void blkcg_pre_destroy(struct cgroup *cgroup) > { > struct blkcg *blkcg = cgroup_to_blkcg(cgroup); > > @@ -622,7 +622,6 @@ static int blkcg_pre_destroy(struct cgroup *cgroup) > } > > spin_unlock_irq(&blkcg->lock); > - return 0; Looks good from blk-cgroup perspective. ACK for these bits. Thanks Vivek _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers