Zhao Hongjiang <zhaohongjiang37@xxxxxxxxx> writes: >>> >>> i_uid_write(inode, (uid_t)raw_inode->i_uid); >>> i_gid_write(inode, (gid_t)raw_inode->i_gid); >>> >>> is more better? >> >> An extra cast to uid_t or gid_t is redundant. i_uid_write takes >> a uid_t paramenter and i_gid_write takes a gid_t paramenter so >> we already have the casts implicitly. >> >> Eric > > I see,this is mean that we should remove uid_t and gid_t casts in other patches which > is in i_uid_write and i_gid_write? Do you know of any such cases. I certainly don't remember extraneous casts be a usual pattern in the kernel. Eric _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
