From: Huang Qiang <h.huangqiang@xxxxxxxxxx>
Date: Mon, 9 Jul 2012 14:05:09 +0800
> From: Yang Zhenzhang <yangzhenzhang@xxxxxxxxxx>
>
> Now, kernel allows each net namespace to independently set up its levels
> for tcp memory pressure thresholds.
>
> But it seems there is a bug, as using the following steps:
>
> [root@host socket]# lxc-start -n test -f config /bin/bash
> [root@net-test socket]# ip route add default via 192.168.58.2
> [root@net-test socket]# echo 0 0 0 > /proc/sys/net/ipv4/tcp_mem
> [root@net-test socket]# scp root@192.168.58.174:/home/tcp_mem_test .
>
> and it still can transport the "tcp_mem_test" file which we hope it
> would not.
>
> It's because inet_init() (net/ipv4/af_inet.c)initialize the
> tcp_prot.sysctl_mem:
> tcp_prot.sysctl_mem = init_net.ipv4.sysctl_tcp_mem;
>
> So when the protocal is TCP, sk->sk_prot->sysctl_mem(following code)
> always use the ipv4 sysctl_tcp_mem of init_net namespace rather than
> it's own net namespace.
> This patch simply set "prot" equal to net->ipv4.sysctl_tcp_mem when
> the protocol type is TCP.
>
> Signed-off-by: Yang Zhenzhang <yangzhenzhang@xxxxxxxxxx>
Another regression added by the socket memory cgroup code, BIG
SURPRISE.
But this patch is even worse than the bug.
> long *prot = sk->sk_prot->sysctl_mem;
> +
^^^^^^^^
Trailing whitespace please remove.
Also, this patch causes build failures:
In file included from include/linux/tcp.h:227:0,
from include/linux/ipv6.h:221,
from include/net/ipv6.h:16,
from include/linux/sunrpc/clnt.h:26,
from include/linux/nfs_fs.h:57,
from init/do_mounts.c:30:
include/net/sock.h: In function ʽsk_prot_mem_limitsʼ:
include/net/sock.h:1066:9: error: implicit declaration of function ʽsock_netʼ [-Werror=implicit-function-declaration]
include/net/sock.h:1066:20: warning: initialization makes pointer from integer without a cast [enabled by default]
include/net/sock.h:1069:8: error: ʽconst struct sockʼ has no member named ʽprotocolʼ
include/net/sock.h: At top level:
include/net/sock.h:2136:13: error: conflicting types for ʽsock_netʼ
include/net/sock.h:1066:20: note: previous implicit declaration of ʽsock_netʼ was here
cc1: some warnings being treated as errors
It is basically impossible that you even compile tested this patch
because you're using an interface from the same header file before
it's even defined.
This is an incredibly poor patch submission, I hate to tell you.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
