On Fri, May 18, 2012 at 7:55 PM, Tejun Heo <tj@xxxxxxxxxx> wrote: > On Thu, May 17, 2012 at 12:33:05AM +0200, Sasha Levin wrote: >> Hi Tejun, >> >> On Sun, Apr 1, 2012 at 8:54 PM, Tejun Heo <tj@xxxxxxxxxx> wrote: >> > Hello, Li. >> > >> > On Sun, Apr 01, 2012 at 10:00:26AM +0800, Li Zefan wrote: >> >> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> >> >> >> >> Both patches look good. >> >> >> >> Acked-by: Li Zefan <lizefan@xxxxxxxxxx> >> > >> > Alright, adding the patches to cgroup/for-3.5. >> >> This patch allows for race when removing a cgroup since one of the >> css's may still have a dentry ref when the cgroup is removed, no? Is >> there a plan to deal with that before this patch gets pushed into 3.5? > > Can you please elaborate? >From what I gathered, that patch means that you'll have refs to dentries while you're trying to complete the unmount of the cgroup, which would make something really angry. I tested it by running two scripts to race with eachother: First: while [ true ]; do mount -t cgroup dummy cgroup/ mkdir cgroup/0 rmdir cgroup/0 umount cgroup/ done Second: while [ true ]; do mount -t cgroup dummy cgroup/ umount cgroup/ done Now, if you give it a go, you'll see a BUG() and a system hang pretty fast. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
