Tejun Heo wrote:
> With memcg converted, cgroup_subsys->populate() doesn't have any user
> left. Remove it.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
> Li, can you please ack this? Thanks.
You forgot to update Documentation/cgroups/cgroups.txt. ;)
And with that:
Acked-by: Li Zefan <lizefan@xxxxxxxxxx>
>
> include/linux/cgroup.h | 1 -
> kernel/cgroup.c | 3 ---
> 2 files changed, 4 deletions(-)
>
> diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
> index 565c803..d3f5fba 100644
> --- a/include/linux/cgroup.h
> +++ b/include/linux/cgroup.h
> @@ -472,7 +472,6 @@ struct cgroup_subsys {
> void (*fork)(struct task_struct *task);
> void (*exit)(struct cgroup *cgrp, struct cgroup *old_cgrp,
> struct task_struct *task);
> - int (*populate)(struct cgroup_subsys *ss, struct cgroup *cgrp);
> void (*post_clone)(struct cgroup *cgrp);
> void (*bind)(struct cgroup *root);
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 2905977..b2f203f 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -3842,9 +3842,6 @@ static int cgroup_populate_dir(struct cgroup *cgrp)
> for_each_subsys(cgrp->root, ss) {
> struct cftype_set *set;
>
> - if (ss->populate && (err = ss->populate(ss, cgrp)) < 0)
> - return err;
> -
> list_for_each_entry(set, &ss->cftsets, node)
> cgroup_addrm_files(cgrp, ss, set->cfts, true);
> }
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/containers
