Quoting Matt Helsley (matthltc@xxxxxxxxxx): > On Wed, Nov 09, 2011 at 08:18:53AM -0600, Serge E. Hallyn wrote: > > Quoting Andrew Morton (akpm@xxxxxxxxxxxxxxxxxxxx): > > > On Fri, 4 Nov 2011 22:24:37 +0000 > > > Serge Hallyn <serge@xxxxxxxxxx> wrote: > > > > > > > +static inline void fixup_uid(struct siginfo *info, struct task_struct *t) > > nit: Seems like the function name itself needs a fixup. I can imagine a > user-ns-unaware kernel developer thinking this when they see code calling > this function: > > <naive> > Gosh, why is the uid broken? I have no idea what this does or when it > would be needed. Why hasn't it been splatted all over the kernel? Who broke > it? > </naive> > > You can't even tell from the name that it's for user namespaces. Heh, my first reaction was that you're over-reacting, but you're probably right. I don't want to conflict with the 'user_ns_map_uids' function, so how about userns_fixup_signal_uids()? Pls let me know if you have a better name, otherwise I'll switch to this one. thanks, -serge _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/containers
