On 09/07/2011 02:24 AM, Paul Menage wrote:
> On Tue, Sep 6, 2011 at 9:23 PM, Glauber Costa<glommer@xxxxxxxxxxxxx> wrote:
>> +
>> +struct kmem_cgroup {
>> + struct cgroup_subsys_state css;
>> + struct kmem_cgroup *parent;
>> +};
>
> There's a parent pointer in css.cgroup, so you shouldn't need a
> separate one here.
Ok, I missed that. Thanks
> Most cgroup subsystems define this structure (and the below accessor
> functions) in their .c file rather than exposing it to the world? Does
> this subsystem particularly need it exposed?
Originally I was using it in sock.c and friends. Now, from the last
submission to this one, most of those uses were substituted. The
acessors, however, are in kmem_cgroup.h. Reason being I want most of
them to be inline.
>> +
>> +static struct cgroup_subsys_state *kmem_create(
>> + struct cgroup_subsys *ss, struct cgroup *cgrp)
>> +{
>> + struct kmem_cgroup *sk = kzalloc(sizeof(*sk), GFP_KERNEL);
>
> kcg or just cg would be a better name?
I'll go with kcg.
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
