Hello,
On Tue, Sep 06, 2011 at 05:25:39PM +0200, Oleg Nesterov wrote:
> On 09/06, Oleg Nesterov wrote:
> >
> > Yes, agreed. In this case I think it should be
> >
> > #define wait_event_freezable(wq, condition) \
> > ({ \
> > int __retval; \
> > for (;;) { \
> > __retval = wait_event_interruptible(wq, \
> > (condition) || freezing(current)); \
> > if (__retval || (condition)) \
> > break; \
> > try_to_freeze(); \
> > } \
> > __retval; \
> > })
> >
> > __retval/ERESTARTSYS is only needed for kthreads which play with allow_signal(),
> > probably nobody should do this.
>
> I meant, unless the caller plays with allow_signal(), it has all rights to do
>
> if (wait_event_freezable(...))
> BUG();
>
> This becomes correct with the code above.
Yeap, sure, w/ freezable_with_signal gone, the above should work fine.
Care to create a patch?
Thanks.
--
tejun
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
