On Fri, Jul 15, 2011 at 05:49:08PM +0400, Pavel Emelyanov wrote:
<snip>
> static void kill_imgfiles(int pid)
> {
> /* FIXME */
> }
>
> static int stop_task(int pid)
> {
> return kill(pid, SIGSTOP);
> }
Shouldn't you wait() on the task too? Otherwise I think you'll race
with it. Alternately, you could introduce a wait() phase after the loop
calls stop_task() below...
<snip>
>
> static int __dump_all_tasks(void)
> {
> int i, pid;
>
> printf("Dumping tasks' images for");
> for (i = 0; i < nr_pids; i++)
> printf(" %d", pids[i]);
> printf("\n");
>
> printf("Stopping tasks\n");
> for (i = 0; i < nr_pids; i++)
> if (stop_task(pids[i]))
> goto err;
(see the wait() note above)
>
> for (i = 0; i < nr_pids; i++) {
> if (dump_one_task(pids[i], 0))
> goto err;
> }
>
> printf("Resuming tasks\n");
> for (i = 0; i < nr_pids; i++)
> continue_task(pids[i]);
>
> return 0;
>
> err:
> for (i = 0; i < nr_pids; i++)
> continue_task(pids[i]);
nit: Seems like you could simplify this using a variable with
the return value.
> return 1;
>
> }
<snip>
>
> static int fixup_pages_data(int pid, int fd)
> {
> char path[128];
> int shfd;
> __u32 mag;
> __u64 vaddr;
>
> sprintf(path, "pages-%d.img", pid);
> shfd = open(path, O_RDONLY);
> if (shfd < 0) {
> perror("Can't open shmem image");
> return 1;
> }
>
> read(shfd, &mag, sizeof(mag));
> if (mag != PAGES_MAGIC) {
> fprintf(stderr, "Bad shmem image\n");
> return 1;
> }
>
> lseek(fd, -sizeof(struct binfmt_page_image), SEEK_END);
> read(fd, &vaddr, sizeof(vaddr));
> if (vaddr != 0) {
> printf("SHIT %lx\n", (unsigned long)vaddr);
Typo?
Cheers,
-Matt Helsley
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
