Re: [PATCH] c/r: Initialize msg_msg security pointer at restart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Jose R. Santos (jrs@xxxxxxxxxxxxxxxxxx):
> This small oversight was causing either crashes on free_msg() or
> restart failures under some message queue workloads.
> 
> Signed-off-by: Jose R. Santos <jrs@xxxxxxxxxxxxxxxxxx>

What kernel is this?

Starting with the last line in your context, there is:

	/* set default MAC attributes */
	ret = security_msg_msg_alloc(msg);
	if (ret < 0)
		goto out;

which should take care of that.  I don't know of an LSM which
doesn't define msg_msg_alloc() but does define msg_msg_free().
Do you have a stack trace to show where it was getting
freed?

> CC: Oren Laadan <orenl@xxxxxxxxxxxxxxx>
> ---
>  ipc/checkpoint_msg.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/ipc/checkpoint_msg.c b/ipc/checkpoint_msg.c
> index 0a19d1f..6fa2c8e 100644
> --- a/ipc/checkpoint_msg.c
> +++ b/ipc/checkpoint_msg.c
> @@ -233,6 +233,7 @@ static struct msg_msg *restore_msg_contents_one(struct ckpt_ctx *ctx, int *clen)
>  		goto out;
>  	}
>  	msg->next = NULL;
> +        msg->security = NULL;
>  	pseg = &msg->next;
>  
>  	/* set default MAC attributes */
> -- 
> 1.7.1
> 
> _______________________________________________
> Containers mailing list
> Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
> https://lists.linux-foundation.org/mailman/listinfo/containers

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers

[Index of Archives]     [Cgroups]     [Netdev]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux