[...] >> + file = fget(fds[1-which]); >> + if (!file) /* this should _never_ happen ! */ > > If it should never happen then this should be: > > BUG_ON(!file); > > that way we see the bug as soon as it's detected rather than having to > dig through the stack and 'step' through the code to figure out the > source of EBADF. I noticed Oren applied this patch and the same never > assertion was made in a few other places so I've inlined a patch. Ok. Queued for v23-rc2. Oren. _______________________________________________ Containers mailing list Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/containers
