Hi,
I'm not too familiar with all the uses of VM_{IO,RESERVED,PFNMAP}
flags. Should I be concerned about missing out cases where the
checkpoint succeeds but the restart will fail (or worse, succeed
but not work correctly thereafter) ?
If these are only "used" by devices, then no problem - they won't
checkpoint unless they have the code to support c/r. But are
they used elsewhere ?
If so, perhaps we should find a way to encode these constraints
differently, e.g., only allow these flags if there is vma->vm_file
which has a .checkpoint operation valid ?
Oren.
On 10/20/2010 02:56 PM, Nathan Lynch wrote:
> This is necessary for checkpoint/restart of BSR device (and likely
> hpet and other timer device) mappings.
>
> Signed-off-by: Nathan Lynch <ntl@xxxxxxxxx>
> ---
> include/linux/checkpoint.h | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
> index a02f27a..df0a9ed 100644
> --- a/include/linux/checkpoint.h
> +++ b/include/linux/checkpoint.h
> @@ -313,12 +313,9 @@ extern int restore_memory_contents(struct ckpt_ctx *ctx, struct inode *inode);
> #define CKPT_VMA_NOT_SUPPORTED ( \
> VM_HUGETLB | \
> VM_INSERTPAGE | \
> - VM_IO | \
> VM_MAPPED_COPY | \
> VM_MIXEDMAP | \
> VM_NONLINEAR | \
> - VM_PFNMAP | \
> - VM_RESERVED | \
> VM_SAO | \
> 0)
>
_______________________________________________
Containers mailing list
Containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/containers
